qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 32/33] docs/qapi-code-gen.txt: Fix QAPI schema e


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 32/33] docs/qapi-code-gen.txt: Fix QAPI schema examples
Date: Thu, 3 Sep 2015 08:32:08 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 09/03/2015 03:55 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  docs/qapi-code-gen.txt | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 

>  
> - { 'enum': 'BlockdevDriver', 'data': [ 'raw', 'qcow2' ] }
> + { 'enum': 'BlockdevDriver', 'data': [ 'file', 'qcow2' ] }

Done to match actual usage.

>   { 'struct': 'BlockdevCommonOptions',
>     'data': { 'driver': 'BlockdevDriver', 'readonly': 'bool' } }
>   { 'union': 'BlockdevOptions',
> @@ -350,7 +349,7 @@ is identical on the wire to:
>   { 'struct': 'Base', 'data': { 'type': 'Enum' } }
>   { 'struct': 'Branch1', 'data': { 'data': 'str' } }
>   { 'struct': 'Branch2', 'data': { 'data': 'int' } }
> - { 'union': 'Flat': 'base': 'Base', 'discriminator': 'type',
> + { 'union': 'Flat', 'base': 'Base', 'discriminator': 'type',

and done to fix a blatant type of : instead of ,

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]