[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v3 02/32] qapi: New QAPISchema intermediate
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC v3 02/32] qapi: New QAPISchema intermediate reperesentation |
Date: |
Thu, 3 Sep 2015 08:52:13 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/31/2015 12:09 PM, Markus Armbruster wrote:
>>>>>
>>>>> since we don't allow 2D arrays?
>>>>
>>>> If the generators actually rely on it, yes.
> The appended experimental frontend patch passes "make check". Looks
> like the backends are just fine with arrays of arrays. I'll therefore
> refrain from adding "element type isn't array" assertions to backends.
>
> Since there's plenty of QAPI work on list already, I'll shelve this
> patch for now. We can revisit nested arrays later.
Another thing to think about if we allow nested arrays: patch 31/32 maps
'uint8' to 'int', and ['uint8'] to ['int'], but leaves [['uint8']]
untouched. We'd have to add a while loop in qapi-introspect.py to
ensure we drill down through all levels of an array.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH RFC v3 02/32] qapi: New QAPISchema intermediate reperesentation,
Eric Blake <=