[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for gues
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for guest_base == 0 |
|
Date: |
Thu, 3 Sep 2015 19:33:32 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
Am 01.09.2015 um 22:07 schrieb Richard Henderson:
> In ffc6372851d8631a9f9fa56ec613b3244dc635b9, we swapped the guest
> base to the address base register from the address index register.
> Except that 31 in the base slot is SP not XZR, so we need to be
> more intelligent about which reg gets placed in which slot.
>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Aurelien Jarno <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Cc: address@hidden (v2.4.0)
> Reported-by: Andreas Färber <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> tcg/aarch64/tcg-target.c | 27 ++++++++++++++++++++-------
> 1 file changed, 20 insertions(+), 7 deletions(-)
Tested-by: Andreas Färber <address@hidden>
Fixes my test case, thanks.
Backporting it to v2.4.0 was a little complicated due to the guest base
changes though, still waiting on results from our build service there.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)