Re: [Qemu-devel] [PATCH RFC v4 00/32] qapi: QMP introspection

[Eric Blake]

On 09/04/2015 06:57 AM, Marc-André Lureau wrote:
> Hi Markus
> 
> On Thu, Sep 3, 2015 at 4:29 PM, Markus Armbruster <address@hidden> wrote:
>> Series is based on "[PATCH 00/26] qapi: Another round of fixes and
>> cleanups" (which actually has 33 patches now).  It also needs my
>> "[PATCH for-2.4 0/2] qom: Fix misuse of Error API" to pass tests.
>>
>> You can fetch it from my git://repo.or.cz/qemu/armbru.git branch
>> qapi-introspect.
> 
> For the records, I have also rebased my qapi-related patches on top of
> your branch. It adds: varargs support, doc generation, use of
> qmp_dispatch() & async support.
> 
> https://github.com/elmarco/qemu branch qapi
> 

I don't think we want varargs; you added it for 'netdev_add', but the
right fix for that is to use a flat union type and fix 'command' to
allow a boxed union argument, rather than adding an untyped varargs.

I guess I need to rebase my pending patches, and get them posted, since
it touches some of the same things.  We'll get netdev_add fixed soon
enough :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature