Re: [Qemu-devel] [PATCH v5 2/5] migration: Parameters for auto-converge cpu throttling

[Jason J. Herne]

On 09/01/2015 05:26 PM, Eric Blake wrote:
> On 09/01/2015 08:46 AM, Jason J. Herne wrote:
> > Add migration parameters to allow the user to adjust the parameters
> > that control cpu throttling when auto-converge is in effect. The added
> > parameters are as follows:
> >
> > x-cpu-throttle-initial : Initial percantage of time guest cpus are throttled
> > when migration auto-converge is activated.
> >
> > x-cpu-throttle-increment: throttle percantage increase each time
> > auto-converge detects that migration is not making progress.
>
> Marked experimental; do we think it will be promoted to stable before
> 2.5 is released?

Not a clue :) I have no idea how things move from x- to sans x-.

> What happens if I set throttle-initial to 50 and throttle-increment to
> 50?  The previous patch required throttle percentage to be between 1 and
> 99 inclusive; does that mean I cap out at 99 instead of an invalid
> throttle of 100?

The call to cpu_throttle_set will take care of the capping. Details
provided in previous reply :)
...
> We've missed 2.4; these lines need to say (Since 2.5).
...
> >   # Since: 2.4
...
> Would be nice to document the default (20).
...
> And again (10).  Also, same comment about needing 2.5.

I will fix all of these.

--
-- Jason J. Herne (address@hidden)