qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V4 1/8] i2cbus: remove unused dev field.


From: Alistair Francis
Subject: Re: [Qemu-devel] [PATCH V4 1/8] i2cbus: remove unused dev field.
Date: Fri, 4 Sep 2015 16:43:25 -0700

On Fri, Sep 4, 2015 at 3:50 PM, Frederic Konrad
<address@hidden> wrote:
> On 01/09/2015 22:58, Alistair Francis wrote:
>>
>> On Tue, Jul 21, 2015 at 10:17 AM,  <address@hidden> wrote:
>>>
>>> From: KONRAD Frederic <address@hidden>
>>>
>>> Seems this field is not needed.
>>
>> The commit message should be updated to represent the patch.
>
> Hmmm what do you mean?
> It's not precise?

Hey Fred,

The commit message should make sense without the commit title.

Thanks,

Alistair

>
> Thanks,
> Fred
>
>
>>
>>> Signed-off-by: KONRAD Frederic <address@hidden>
>>
>> Otherwise:
>>
>> Reviewed-by: Alistair Francis <address@hidden>
>>
>> Thanks,
>>
>> Alistair
>>
>>> ---
>>>   hw/i2c/core.c | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/hw/i2c/core.c b/hw/i2c/core.c
>>> index 5a64026..e0f92de 100644
>>> --- a/hw/i2c/core.c
>>> +++ b/hw/i2c/core.c
>>> @@ -13,7 +13,6 @@ struct I2CBus
>>>   {
>>>       BusState qbus;
>>>       I2CSlave *current_dev;
>>> -    I2CSlave *dev;
>>>       uint8_t saved_address;
>>>   };
>>>
>>> --
>>> 1.9.0
>>>
>>>
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]