[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/4] CODING_STYLE: update mixed declaration rules
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 1/4] CODING_STYLE: update mixed declaration rules |
Date: |
Mon, 7 Sep 2015 11:53:01 +0200 |
Mixed declarations also do exist at the top of #ifdef blocks.
Reluctantly allow this particular usage and suggest an alternative.
Signed-off-by: Paolo Bonzini <address@hidden>
---
CODING_STYLE | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/CODING_STYLE b/CODING_STYLE
index d46cfa5..3c6978f 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -87,10 +87,15 @@ Furthermore, it is the QEMU coding style.
5. Declarations
-Mixed declarations (interleaving statements and declarations within blocks)
-are not allowed; declarations should be at the beginning of blocks. In other
-words, the code should not generate warnings if using GCC's
--Wdeclaration-after-statement option.
+Mixed declarations (interleaving statements and declarations within
+blocks) are generally not allowed; declarations should be at the beginning
+of blocks.
+
+Every now and then, an exception is made for declarations inside a
+#ifdef or #ifndef block: if the code looks nicer, such declarations can
+be placed at the top of the block even if there are statements above.
+On the other hand, however, it's often best to move that #ifdef/#ifndef
+block to a separate function altogether.
6. Conditional statements
--
2.4.3
- [Qemu-devel] [PATCH 0/4] updates to coding style and checkpatch, Paolo Bonzini, 2015/09/07
- [Qemu-devel] [PATCH 1/4] CODING_STYLE: update mixed declaration rules,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 2/4] CODING_STYLE, checkpatch: update line length rules, Paolo Bonzini, 2015/09/07
- Re: [Qemu-devel] [PATCH 2/4] CODING_STYLE, checkpatch: update line length rules, Thomas Huth, 2015/09/07
- Re: [Qemu-devel] [PATCH 2/4] CODING_STYLE, checkpatch: update line length rules, Paolo Bonzini, 2015/09/07
- Re: [Qemu-devel] [PATCH 2/4] CODING_STYLE, checkpatch: update line length rules, Thomas Huth, 2015/09/07
- Re: [Qemu-devel] [PATCH 2/4] CODING_STYLE, checkpatch: update line length rules, Markus Armbruster, 2015/09/07
- Re: [Qemu-devel] [PATCH 2/4] CODING_STYLE, checkpatch: update line length rules, Paolo Bonzini, 2015/09/07
- Re: [Qemu-devel] [PATCH 2/4] CODING_STYLE, checkpatch: update line length rules, Markus Armbruster, 2015/09/07
- Re: [Qemu-devel] [PATCH 2/4] CODING_STYLE, checkpatch: update line length rules, John Snow, 2015/09/09