Re: [Qemu-devel] [PATCH] scripts/dump-guest-memory.py: fix after RAMBlock change

[Paolo Bonzini]

On 27/08/2015 11:06, Michael S. Tsirkin wrote:
> commit 9b8424d5735278ca382f11adc7c63072b632ab83
>     "exec: split length -> used_length/max_length"
> changed field names in struct RAMBlock
> 
> It turns out that scripts/dump-guest-memory.py was
> poking at this field, update it accordingly.
> 
> Cc: address@hidden
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>  scripts/dump-guest-memory.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py
> index dc8e44a..08796ff 100644
> --- a/scripts/dump-guest-memory.py
> +++ b/scripts/dump-guest-memory.py
> @@ -118,7 +118,7 @@ shape and this command should mostly work."""
>      def qemu_get_ram_block(self, ram_addr):
>          ram_blocks = gdb.parse_and_eval("ram_list.blocks")
>          for block in self.qlist_foreach(ram_blocks, "next"):
> -            if (ram_addr - block["offset"] < block["length"]):
> +            if (ram_addr - block["offset"] < block["used_length"]):
>                  return block
>          raise gdb.GdbError("Bad ram offset %x" % ram_addr)
>  
> 

Thanks, queued for my next pull request.

Paolo