[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 1/5] cpu: Provide vcpu throttling interface
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v6 1/5] cpu: Provide vcpu throttling interface |
Date: |
Mon, 7 Sep 2015 16:08:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
Am 07.09.2015 um 14:53 schrieb Paolo Bonzini:
> On 04/09/2015 18:26, Jason J. Herne wrote:
>> + pct = (double)cpu_throttle_get_percentage()/100;
>> + throttle_ratio = pct / (1 - pct);
>> + sleeptime_ms = (long)(throttle_ratio * CPU_THROTTLE_TIMESLICE);
>
> This is going to be pretty imprecise, since there are only 11 possible
> values of sleeptime_ms. Can you switch the timer and
> CPU_THROTTLE_TIMESLICE to nanosecond precision instead?
>
> It's okay to provide this as a patch 6/5, and the maintainer will squash
> it into this patch. Alternatively this can be sent as v7, as you prefer.
I'm assuming "the maintainer" refers to Juan for this series. ;)
I've been waiting for you guys to reach consensus - only nit I have is
that two colons are missing after "Returns" in the documentation.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
- [Qemu-devel] [PATCH v6 0/5] migration: Dynamic cpu throttling for auto-converge, Jason J. Herne, 2015/09/04
- [Qemu-devel] [PATCH v6 2/5] migration: Parameters for auto-converge cpu throttling, Jason J. Herne, 2015/09/04
- [Qemu-devel] [PATCH v6 4/5] qmp/hmp: Add throttle ratio to query-migrate and info migrate, Jason J. Herne, 2015/09/04
- [Qemu-devel] [PATCH v6 5/5] migration: Disambiguate MAX_THROTTLE, Jason J. Herne, 2015/09/04
- [Qemu-devel] [PATCH v6 1/5] cpu: Provide vcpu throttling interface, Jason J. Herne, 2015/09/04
- [Qemu-devel] [PATCH v6 3/5] migration: Dynamic cpu throttling for auto-converge, Jason J. Herne, 2015/09/04