Re: [Qemu-devel] [PATCH FYI 29/46] migration: remove use of qemu_bufopen from vmstate tests

[Daniel P. Berrange]

On Mon, Sep 07, 2015 at 05:08:17PM +0100, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (address@hidden) wrote:
> > The test-vmstate.c file is the only remaining user of the
> > qemu_bufopen function. Half of the test cases already use
> > a temporary file, so convert the remaining cases to match
> 
> As mentioned on irc; the buffered stuff is used by the postcopy
> series and COLO.

Yep, there's nothing in my series (yet) that really requires
that we delete this QEMUFile impl. I was just trying to see
if it was possible to get to a point where the /only/ QEMUFile
impl was the QIOChannel one. I almost succeeded in that, the
exception being the impl needed for writing internal QCow2
snapshots. I'll look at creating a memory buffer based
QIOChannel, or alternatively just drop this patch, to avoid
breaking COLO/postcopy.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|