Re: [Qemu-devel] [PATCH qemu] spapr: Enable in-kernel H_SET_MODE handling

[David Gibson]

On Sun, Sep 06, 2015 at 04:14:25PM +1000, Alexey Kardashevskiy wrote:
> On 09/04/2015 02:48 PM, David Gibson wrote:
> >On Wed, Sep 02, 2015 at 07:29:58PM +1000, Alexey Kardashevskiy wrote:
> >>For setting debug watchpoints, sPAPR guests use H_SET_MODE hypercall.
> >>The existing QEMU H_SET_MODE handler does not support this but
> >>the KVM handler in HV KVM does. However it is not enabled.
> >>
> >>This enables the in-kernel H_SET_MODE handler which handles:
> >>- Completed Instruction Address Breakpoint Register
> >>- Watch point 0 registers.
> >>
> >>The rest is still handled in QEMU.
> >>
> >>Reported-by: Anton Blanchard <address@hidden>
> >>Signed-off-by: Alexey Kardashevskiy <address@hidden>
> >
> >Applied to spapr-dev; I'll move it into spapr-next once it's had a
> >little more testing.
> 
> Another thing to keep in mind is that at some point in the past the host
> kernel used to handle H_SET_MODE and QEMU did not have the handler at all,
> now this functionality is in QEMU but some RHEL kernel could have picked a
> kernel with the in-kernel handler.

Not one that's supported as a KVM host, I believe.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

pgppSLfY5ZPAf.pgp
Description: PGP signature