Re: [Qemu-devel] [PATCH v6 00/11] Extract TLS handling code from VNC server

[Gerd Hoffmann]

  Hi,

> I think the patches are great, and I'm not sure if anyone is in a better
> position than you to decide if they're ready.

Lets have a look:

# scripts/get_maintainer.pl -f crypto
"Daniel P. Berrange" <address@hidden> (maintainer:Cryptography)

> I don't even know if anyone really understands the VNC TLS code and
> thus can review patch 11. :)  So I would just ask you to send a pull
> request.

Agree.  Don't be shy, send a pull request.  Including the vnc bits is
fine with me.  I've briefly looked over the vnc changes, they look sane
to me, and consolidating all the crypto stuff in a nice, reusable way
instead of sprinkling gnutls ifdefs all over the place (including vnc)
certainly is a step into the right direction.

cheers,
  Gerd