Re: [Qemu-devel] [PATCH v1 07/10] target-arm: Supress the use of TTBR1 for S2 translations

[Peter Maydell]

On 3 September 2015 at 21:14, Edgar E. Iglesias
<address@hidden> wrote:
> From: "Edgar E. Iglesias" <address@hidden>
>
> Stage-2 MMU translations do not use TTBR1.
>
> Signed-off-by: Edgar E. Iglesias <address@hidden>
> ---
>  target-arm/helper.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 9ea9719..66b3fed 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -6372,6 +6372,11 @@ static bool get_phys_addr_lpae(CPUARMState *env, 
> target_ulong address,
>          }
>      }
>
> +    /* Stage2 translations do not use TTBR1.  */
> +    if (mmu_idx == ARMMMUIdx_S2NS) {
> +        ttbr1_valid = false;
> +    }
> +

I think this is unnecessary, because we've already set ttbr1_valid
to false in the previous chunk of code for the case where el == 2
(as it is for stage 2 translations).

thanks
-- PMM