Re: [Qemu-devel] [PATCH 5/5] disk_deadlines: add info disk-deadlines option

[Eric Blake]

On 09/08/2015 10:20 AM, Eric Blake wrote:
> On 09/08/2015 02:00 AM, Denis V. Lunev wrote:
>> From: Raushaniya Maksudova <address@hidden>
>>
>> This patch adds "info disk-deadlines" qemu-monitor option that prints
>> dump of all disk requests which caused a disk deadline in Guest OS
>> from the very start of Virtual Machine:
>>

> 
> qapi interface review only:
> 

> Should it be possible to filter to deadlines missed for a specific node,
> by having an arguments with an optional node name?
> 
> Should any of the existing query-block or similar commands be modified
> to make it obvious that there are missed deadline stats, and that it
> would be useful to call query-disk-deadlines to learn more about them?

Also, should there be an event raised when a timeout occurs, so that
management doesn't have to poll this API?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature