Re: [Qemu-devel] [PATCH 2/7] qapi: convert NumaOptions into a flat union

[Eduardo Habkost]

On Mon, Sep 07, 2015 at 02:08:07PM +0200, Kővágó, Zoltán wrote:
[...]
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 67fef37..9e4fe5d 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3550,17 +3550,6 @@
>    'data': { '*console':'int', 'events': [ 'InputEvent' ] } }
>  
>  ##
> -# @NumaOptions
> -#
> -# A discriminated record of NUMA options. (for OptsVisitor)
> -#
> -# Since 2.1
> -##
> -{ 'union': 'NumaOptions',
> -  'data': {
> -    'node': 'NumaNodeOptions' }}
> -
> -##
>  # @NumaNodeOptions
>  #
>  # Create a guest NUMA node. (for OptsVisitor)
> @@ -3587,6 +3576,42 @@
>     '*memdev': 'str' }}
>  
>  ##
> +# @NumaOptionType
> +#
> +# List of possible numa drivers.

There's no such thing as a "numa driver". The type name was fixed but
the documentation still doesn't make sense.

I suggest:

# NUMA command-line option type.
#
# @node: Create a guest NUMA node. See @NumaNodeOptions.

> +#
> +# Since: 2.5
> +##
> +{ 'enum': 'NumaOptionType',
> +  'data': [ 'node' ] }
> +
> +##
> +# @NumaCommonOptions
> +#
> +# Common set of numa options.
> +#
> +# @type: the numa driver to use

Suggestion:

# @type: NUMA command-line option type.

-- 
Eduardo