[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] net: use Netdev instead of NetClientOptions
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] net: use Netdev instead of NetClientOptions in client init |
Date: |
Wed, 9 Sep 2015 09:46:56 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/07/2015 06:14 AM, Kővágó, Zoltán wrote:
> This way we no longer need NetClientOptions and can convert Netdev
> into a flat union.
>
> Signed-off-by: Kővágó, Zoltán <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
I may have reviewed this one, but I'm still not a fan of 3/7. Give me a
chance to post my introspection followup patches that cherry-pick pieces
of your work and make QMP netdev_add a full-fledged qapi-fied command;
I'll keep you on cc when I post.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/7] qapi-flattening and preparation of -audiodev option, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 1/7] qapi: support implicit structs in OptsVisitor, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 2/7] qapi: convert NumaOptions into a flat union, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 3/7] net: remove NetLegacy struct, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 6/7] qapi: reorder NetdevBase and Netdev, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 4/7] net: use Netdev instead of NetClientOptions in client init, Kővágó, Zoltán, 2015/09/07
- Re: [Qemu-devel] [PATCH 4/7] net: use Netdev instead of NetClientOptions in client init,
Eric Blake <=
- [Qemu-devel] [PATCH 7/7] qapi: support nested structs in OptsVisitor, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 5/7] qapi: change Netdev into a flat union, Kővágó, Zoltán, 2015/09/07
- Re: [Qemu-devel] [PATCH 0/7] qapi-flattening and preparation of -audiodev option, Markus Armbruster, 2015/09/14