[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 7/7] error: On abort, report where the error was
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL 7/7] error: On abort, report where the error was created |
Date: |
Thu, 10 Sep 2015 10:21:20 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/10/2015 07:32 AM, Markus Armbruster wrote:
> This is particularly useful when we abort in error_propagate(),
> because there the stack backtrace doesn't lead to where the error was
> created. Looks like this:
>
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Acked-by: Laszlo Ersek <address@hidden>
> ---
Already in mainline, but I'm wondering...
> +++ b/util/error.c
> @@ -18,12 +18,23 @@ struct Error
> {
> char *msg;
> ErrorClass err_class;
> + const char *src, *func;
> + int line;
> };
>
Should we also be modifying error_copy() to propagate source information
into the copy?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL 0/7] error: On abort, report where the error was created, Markus Armbruster, 2015/09/10
- [Qemu-devel] [PULL 5/7] error: error_set_errno() is unused, drop, Markus Armbruster, 2015/09/10
- [Qemu-devel] [PULL 1/7] error: De-duplicate code creating Error objects, Markus Armbruster, 2015/09/10
- [Qemu-devel] [PULL 6/7] error: Revamp interface documentation, Markus Armbruster, 2015/09/10
- [Qemu-devel] [PULL 7/7] error: On abort, report where the error was created, Markus Armbruster, 2015/09/10
- Re: [Qemu-devel] [PULL 7/7] error: On abort, report where the error was created,
Eric Blake <=
- [Qemu-devel] [PULL 2/7] error: Make error_setg() a function, Markus Armbruster, 2015/09/10
- [Qemu-devel] [PULL 4/7] qga/vss-win32: Document the DLL requires non-null errp, Markus Armbruster, 2015/09/10
- [Qemu-devel] [PULL 3/7] qga: Clean up unnecessarily dirty casts, Markus Armbruster, 2015/09/10
- Re: [Qemu-devel] [PULL 0/7] error: On abort, report where the error was created, Peter Maydell, 2015/09/10