[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 16/29] xen/pt: xen_host_pci_config_read returns -errn
From: |
Stefano Stabellini |
Subject: |
[Qemu-devel] [PULL 16/29] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure |
Date: |
Thu, 10 Sep 2015 18:15:48 +0100 |
From: Konrad Rzeszutek Wilk <address@hidden>
However the init routines assume that on errors the return
code is -1 (as the libxc API is) - while those xen_host_* routines follow
another paradigm - negative errno on return, 0 on success.
Reviewed-by: Stefano Stabellini <address@hidden>
Signed-off-by: Konrad Rzeszutek Wilk <address@hidden>
Signed-off-by: Stefano Stabellini <address@hidden>
---
hw/xen/xen_pt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index ba043e6..3b1544c 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -729,7 +729,7 @@ static int xen_pt_initfn(PCIDevice *d)
/* Initialize virtualized PCI configuration (Extended 256 Bytes) */
if (xen_host_pci_get_block(&s->real_device, 0, d->config,
- PCI_CONFIG_SPACE_SIZE) == -1) {
+ PCI_CONFIG_SPACE_SIZE) < 0) {
xen_host_pci_device_put(&s->real_device);
return -1;
}
--
1.7.10.4
- [Qemu-devel] [PULL 22/29] xen/pt: Check if reg->init function sets the 'data' past the reg->size, (continued)
- [Qemu-devel] [PULL 22/29] xen/pt: Check if reg->init function sets the 'data' past the reg->size, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 28/29] xen/pt: Check for return values for xen_host_pci_[get|set] in init, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values., Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 14/29] xen/pt: Update comments with proper function name., Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 25/29] xen/pt: Log xen_host_pci_get/set errors in MSI code., Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 24/29] xen/pt: Log xen_host_pci_get in two init functions, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 18/29] xen/pt/msi: Add the register value when printing logging and error messages, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 23/29] xen/pt: Remove XenPTReg->data field., Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 11/29] xen, gfx passthrough: add opregion mapping, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 15/29] xen/pt: Make xen_pt_msi_set_enable static, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 16/29] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure,
Stefano Stabellini <=
- [Qemu-devel] [PULL 27/29] xen/pt: Move bulk of xen_pt_unregister_device in its own routine., Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 20/29] xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 17/29] xen: use errno instead of rc for xc_domain_add_to_physmap, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 19/29] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings., Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 29/29] xen/pt: Don't slurp wholesale the PCI configuration registers, Stefano Stabellini, 2015/09/10
- Re: [Qemu-devel] [PULL 00/29] xen-2015-09-10-tag, Peter Maydell, 2015/09/10