Re: [Qemu-devel] [PATCH 07/12] migration/qemu-file: add qemu_put_counted_string()

[John Snow]

On 08/07/2015 05:32 AM, Vladimir Sementsov-Ogievskiy wrote:
> Add function opposite to qemu_get_counted_string.
> qemu_put_counted_string puts one-byte length of the string (string
> should not be longer than 255 characters), and then it puts the string,
> without last zero byte.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>  include/migration/qemu-file.h | 2 ++
>  migration/qemu-file.c         | 9 +++++++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/include/migration/qemu-file.h b/include/migration/qemu-file.h
> index ea49f33..cfbbdcb 100644
> --- a/include/migration/qemu-file.h
> +++ b/include/migration/qemu-file.h
> @@ -319,4 +319,6 @@ static inline void qemu_get_sbe64s(QEMUFile *f, int64_t 
> *pv)
>  
>  size_t qemu_get_counted_string(QEMUFile *f, char buf[256]);
>  
> +void qemu_put_counted_string(QEMUFile *f, const char *name);
> +
>  #endif
> diff --git a/migration/qemu-file.c b/migration/qemu-file.c
> index 6bb3dc1..206cb54 100644
> --- a/migration/qemu-file.c
> +++ b/migration/qemu-file.c
> @@ -611,3 +611,12 @@ size_t qemu_get_counted_string(QEMUFile *f, char 
> buf[256])
>  
>      return res == len ? res : 0;
>  }
> +
> +void qemu_put_counted_string(QEMUFile *f, const char *name)
> +{
> +    int len = strlen(name);
> +
> +    assert(len < 256);
> +    qemu_put_byte(f, len);
> +    qemu_put_buffer(f, (const uint8_t *)name, len);
> +}
> 

Reviewed-by: John Snow <address@hidden>