Re: [Qemu-devel] [PATCH v2] error: only prepend timestamp on stderr

[Markus Armbruster]

Stefan Hajnoczi <address@hidden> writes:

> The -msg timestamp=on option prepends a timestamp to error messages.
> This is useful on stderr where it allows users to identify when an error
> was raised.
>
> Timestamps do not make sense on the monitor since error_report() is
> called in response to a synchronous monitor command and the user already
> knows "when" the command was issued.  Additionally, the rest of the
> monitor conversation lacks timestamps so the error timestamp cannot be
> correlated with other activity.
>
> Only prepend timestamps on stderr.  This fixes libvirt's 'drive_del'
> processing, which did not expect a timestamp.  Other QEMU monitor
> clients are probably equally confused by timestamps on monitor error
> messages.
>
> Cc: Markus Armbruster <address@hidden>
> Cc: Seiji Aguchi <address@hidden>
> Cc: Frank Schreuder <address@hidden>
> Cc: Daniel P. Berrange <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>

I'll take this through my tree.  Thanks!