qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag
Date: Mon, 14 Sep 2015 11:57:44 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0


On 10/09/2015 12:29, Stefano Stabellini wrote:
> +    if (lseek(config_fd, pos, SEEK_SET) != pos) {
> +        return -errno;
> +    }
>      do {
> -        rc = pread(config_fd, (uint8_t *)&val, len, pos);
> +        rc = read(config_fd, (uint8_t *)&val, len);
>      } while (rc < 0 && (errno == EINTR || errno == EAGAIN));

This leaks config_fd.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]