[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data va
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values. |
Date: |
Mon, 14 Sep 2015 12:01:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 10/09/2015 19:15, Stefano Stabellini wrote:
> +
> + switch (reg->size) {
> + case 1: rc = xen_host_pci_get_byte(&s->real_device, offset, (uint8_t
> *)&val);
A bit ugly, and it relies on the host being little endian.
> + break;
> + case 2: rc = xen_host_pci_get_word(&s->real_device, offset,
> (uint16_t *)&val);
Same here.
> + break;
> + case 4: rc = xen_host_pci_get_long(&s->real_device, offset, &val);
> + break;
> + default: assert(1);
This should be assert(0) or, better, abort().
Paolo
- [Qemu-devel] [PULL 05/29] hw/pci-assign: split pci-assign.c, (continued)
- [Qemu-devel] [PULL 05/29] hw/pci-assign: split pci-assign.c, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 09/29] xen, gfx passthrough: register a isa bridge, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 06/29] xen, gfx passthrough: basic graphics passthrough support, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 08/29] igd gfx passthrough: create a isa bridge, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 26/29] xen/pt: Make xen_pt_unregister_device idempotent, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 13/29] xen/HVM: atomically access pointers in bufioreq handling, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 12/29] xen-hvm: When using xc_domain_add_to_physmap also include errno when reporting, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 22/29] xen/pt: Check if reg->init function sets the 'data' past the reg->size, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 28/29] xen/pt: Check for return values for xen_host_pci_[get|set] in init, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values., Stefano Stabellini, 2015/09/10
- Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values.,
Paolo Bonzini <=
- Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values., Stefano Stabellini, 2015/09/15
- Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values., Konrad Rzeszutek Wilk, 2015/09/15
- Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values., Stefano Stabellini, 2015/09/15
- Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values., Paolo Bonzini, 2015/09/15
- Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values., Konrad Rzeszutek Wilk, 2015/09/15
[Qemu-devel] [PULL 14/29] xen/pt: Update comments with proper function name., Stefano Stabellini, 2015/09/10
[Qemu-devel] [PULL 25/29] xen/pt: Log xen_host_pci_get/set errors in MSI code., Stefano Stabellini, 2015/09/10
[Qemu-devel] [PULL 24/29] xen/pt: Log xen_host_pci_get in two init functions, Stefano Stabellini, 2015/09/10
[Qemu-devel] [PULL 18/29] xen/pt/msi: Add the register value when printing logging and error messages, Stefano Stabellini, 2015/09/10
[Qemu-devel] [PULL 23/29] xen/pt: Remove XenPTReg->data field., Stefano Stabellini, 2015/09/10