[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] pc: check for underflow in load_linux
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH] pc: check for underflow in load_linux |
Date: |
Mon, 14 Sep 2015 12:07:22 +0200 |
If (setup_size+1)*512 is small enough, kernel_size -= setup_size can allocate
a huge amount of memory. Avoid that.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/i386/pc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 56aecce..6a312bd 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -986,6 +986,10 @@ static void load_linux(PCMachineState *pcms,
setup_size = 4;
}
setup_size = (setup_size+1)*512;
+ if (setup_size > kernel_size) {
+ fprintf(stderr, "qemu: invalid kernel header\n");
+ exit(1);
+ }
kernel_size -= setup_size;
setup = g_malloc(setup_size);
--
2.5.0
- [Qemu-devel] [PATCH] pc: check for underflow in load_linux,
Paolo Bonzini <=