[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child |
Date: |
Mon, 14 Sep 2015 17:34:44 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 14.09.2015 um 16:36 hat Markus Armbruster geschrieben:
> Wen Congyang <address@hidden> writes:
> > diff --git a/qmp-commands.hx b/qmp-commands.hx
> > index 495670b..139a23b 100644
> > --- a/qmp-commands.hx
> > +++ b/qmp-commands.hx
> > @@ -4053,6 +4053,59 @@ Example:
> > EQMP
> >
> > {
> > + .name = "x-child-add",
> > + .args_type = "parent:B,child:B",
> > + .mhandler.cmd_new = qmp_marshal_input_x_child_add,
> > + },
> > +
> > +SQMP
> > +x-child-add
> > +------------
> > +
> > +Add a child to a quorum node.
> > +
> > +Arguments:
> > +
> > +- "parent": the quorum's id or node name
> > +- "child": the child node-name which will be added
>
> Node name parameters are usually named node-name or, if there's more
> than one, FOO-node-name. Unless we want to abandon that convention,
> this should therefore be node-name and child-node-name, or parent-node
> name and child-node-name.
Didn't we come to the conclusion that foo-node-name is redundant and
should just be foo, leaving things like node-name only for cases where
there is no foo?
Kevin
- Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add, (continued)
- Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add, Wen Congyang, 2015/09/14
- Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add, Eric Blake, 2015/09/14
- Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add, Wen Congyang, 2015/09/14
- Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add, Eric Blake, 2015/09/15
- Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add, Wen Congyang, 2015/09/16
[Qemu-devel] [PATCH v3 5/5] hmp: add monitor command to add/remove a child, Wen Congyang, 2015/09/10
[Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Wen Congyang, 2015/09/10
- Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Daniel P. Berrange, 2015/09/10
- Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Markus Armbruster, 2015/09/14
- Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Wen Congyang, 2015/09/14
- Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Markus Armbruster, 2015/09/15
- Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Wen Congyang, 2015/09/15
- Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Wen Congyang, 2015/09/16
- Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Markus Armbruster, 2015/09/16
Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Kevin Wolf, 2015/09/14