[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/1] atapi: abort transfers with 0 byte limit
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/1] atapi: abort transfers with 0 byte limits |
|
Date: |
Mon, 14 Sep 2015 12:03:12 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/10/2015 11:11 PM, Fam Zheng wrote:
> On Thu, 09/10 19:20, John Snow wrote:
>>
>> + /* Nondata commands permit the byte_count_limit to be 0.
>> + * If this is a data-transferring PIO command and BCL is 0,
>> + * we abort at the /ATA/ level, not the ATAPI level.
>> + * See ATA8 ACS3 section 7.17.6.49 and 7.21.5 */
>> + if (!(atapi_cmd_table[s->io_buffer[0]].flags & NONDATA)) {
>> + /* TODO: Check IDENTIFY data word 125 for default BCL (currently 0)
>> */
>> + uint16_t byte_count_limit = s->lcyl | (s->hcyl << 8);
>> + if !(byte_count_limit || s->atapi_dma) {
>
> !( ?
>
> Fam
>
Ugh. Thinko'd the outer (), and didn't apparently rebuild. :(