qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] rocker: Use g_new() & friends where that makes


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] rocker: Use g_new() & friends where that makes obvious sense
Date: Mon, 14 Sep 2015 18:11:44 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 09/14/2015 05:57 AM, Jiri Pirko wrote:
>> Mon, Sep 14, 2015 at 01:52:23PM CEST, address@hidden wrote:
>>> g_new(T, n) is neater than g_malloc(sizeof(T) * n).  It's also safer,
>>> for two reasons.  One, it catches multiplication overflowing size_t.
>>> Two, it returns T * rather than void *, which lets the compiler catch
>>> more type errors.
>>>
>>> This commit only touches allocations with size arguments of the form
>>> sizeof(T).  Same Coccinelle semantic patchas in commit b45c03f.
>> 
>>                                            ^ typo :)
>> 
>
> This typo is copy-pasted into ALL of your recent g_new() cleanups. Since
> you did scattershot threads across multiple maintainers rather than one
> big thread, it may be a bit harder to plug all the instances before they
> get pulled through the various trees.

Only three of them, actually: this one, linux-user and qemu-char.

[...]



reply via email to

[Prev in Thread] Current Thread [Next in Thread]