Re: [Qemu-devel] [PATCH v4] monitor: allow device_del to accept QOM paths

[Programmingkid]

On Sep 14, 2015, at 12:41 PM, Eric Blake wrote:

> On 09/14/2015 10:17 AM, Programmingkid wrote:
>> 
>> On Sep 14, 2015, at 11:53 AM, Markus Armbruster wrote:
>> 
>>> "Daniel P. Berrange" <address@hidden> writes:
>>> 
>>>> Currently device_del requires that the client provide the
>>>> device short ID. device_add allows devices may be created
>>> 
>>> "allows devices to be created"
>>> 
>>> Could perhaps be touched up on commit.
>>> 
>>>> without giving an ID, at which point there is no way to
>>>> delete them with device_del. The QOM object path, however,
>>>> provides an alternative way to identify the devices.
>>>> 
> 
>>> If neither Andreas nor Paolo objects, I'd be willing to take this
>>> through my tree.
>> 
>> If you do accept this patch, would you still be willing to
>> accept an auto-generated ID patch still?
> 
> The two are orthogonal.  Deleting by QOM path is useful even if all
> devices are given an id, and auto-generating an id may be useful to
> human users (even though libvirt won't rely on it) regardless of whether
> deleting devices by QOM path is in the tree.
> 
> But you are worrying about nothing; although Kevin is waiting for a v3,
> he has already mentioned on v2 that he is ready to queue auto-generation
> once it works:
> https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00877.html

It has been a while since Kevin asked for a version 3. I wonder if the author
of the patch knows about the version 3 request.