qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4] monitor: allow device_del to accept QOM path


From: Programmingkid
Subject: Re: [Qemu-devel] [PATCH v4] monitor: allow device_del to accept QOM paths
Date: Mon, 14 Sep 2015 12:54:24 -0400

On Sep 14, 2015, at 12:43 PM, Markus Armbruster wrote:

> Programmingkid <address@hidden> writes:
> 
>> On Sep 14, 2015, at 11:53 AM, Markus Armbruster wrote:
> [...]
>>> If neither Andreas nor Paolo objects, I'd be willing to take this
>>> through my tree.
>> 
>> If you do accept this patch, would you still be willing to
>> accept an auto-generated ID patch still?
> 
> I'm on record saying
> 
>    I believe [this patch] makes sense no matter what we do about device
>    IDs (see thread "Should we auto-generate IDs?").
> 
> This patch weakens *one* reason for auto-generated IDs: device_del
> without ID is impossible before, and merely a bit inconvenient after.  I
> haven't been able to keep up with the discussion on auto-generated IDs,
> so I can't currently judge how strong the other reasons are.

I think the main reason to use auto-generated IDs is because they can be
much easier to type than a full QOM path. I know the device_del patch
weaken the reason for auto-generated IDs, it doesn't have to eliminate it. 
We are allowed to have both QOM paths and auto-generated IDs. 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]