[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user/signal.c: Fix several issues for tar
|
From: |
Chen Gang |
|
Subject: |
Re: [Qemu-devel] [PATCH] linux-user/signal.c: Fix several issues for target alpha |
|
Date: |
Tue, 15 Sep 2015 02:35:03 +0800 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 9/15/15 01:13, Richard Henderson wrote:
> On 09/12/2015 08:15 PM, address@hidden wrote:
>> env->ir[IR_RA] = r26;
>> env->ir[IR_PV] = env->pc = ka->_sa_handler;
>> env->ir[IR_A0] = sig;
>> env->ir[IR_A1] = 0;
>> env->ir[IR_A2] = frame_addr + offsetof(struct target_sigframe, sc);
>> env->ir[IR_SP] = frame_addr;
>> +
>> +give_sigsegv:
>> + if (sig == TARGET_SIGSEGV) {
>> + ka->_sa_handler = TARGET_SIG_DFL;
>> + }
>> + force_sig(TARGET_SIGSEGV);
>> }
>
> Fallthrough into the sigsegv handler?
> That's clearly wrong.
>
OK, thanks. Need add "return" before "give_sigsegv". I shall send patch
v2 for it.
Thanks.
--
Chen Gang (陈刚)
Open, share, and attitude like air, water, and life which God blessed