Re: [Qemu-devel] [PATCH v5 04/14] backup: Extract dirty bitmap handling as a separate function

[Fam Zheng]

On Fri, 09/11 13:35, Eric Blake wrote:
> On 09/07/2015 01:34 AM, Fam Zheng wrote:
> > This will be reused by the coming new transactional completion code.
> > 
> > Signed-off-by: Fam Zheng <address@hidden>
> > Reviewed-by: John Snow <address@hidden>
> > ---
> >  block/backup.c | 26 ++++++++++++++++----------
> >  1 file changed, 16 insertions(+), 10 deletions(-)
> > 
> > diff --git a/block/backup.c b/block/backup.c
> > index 965654d..9776d9c 100644
> > --- a/block/backup.c
> > +++ b/block/backup.c
> > @@ -210,6 +210,21 @@ static void backup_iostatus_reset(BlockJob *job)
> >  
> >      bdrv_iostatus_reset(s->target);
> >  }
> > +static void backup_cleanup_sync_bitmap(BackupBlockJob *job, int ret)
> 
> Blank lines between functions?
>

OK, will add one!

Fam