Re: [Qemu-devel] [PATCH v16 18/35] target-tilegx: Handle most bit manipulation instructions

[Peter Maydell]

On 14 September 2015 at 23:43, Richard Henderson <address@hidden> wrote:
> The crc instructions are omitted from this set.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target-tilegx/helper.c    | 10 +++++++
>  target-tilegx/helper.h    |  2 ++
>  target-tilegx/translate.c | 68 
> ++++++++++++++++++++++++++++++++++++++++++++++-
>  3 files changed, 79 insertions(+), 1 deletion(-)
>
> diff --git a/target-tilegx/helper.c b/target-tilegx/helper.c
> index 5b37a8c..a01bb8d 100644
> --- a/target-tilegx/helper.c
> +++ b/target-tilegx/helper.c
> @@ -40,6 +40,16 @@ uint64_t helper_cnttz(uint64_t arg)
>      return ctz64(arg);
>  }
>
> +uint64_t helper_pcnt(uint64_t arg)
> +{
> +    return ctpop64(arg);
> +}
> +
> +uint64_t helper_revbits(uint64_t arg)
> +{
> +    return revbit64(arg);
> +}
> +
>  /*
>   * Functional Description
>   *     uint64_t a = rf[SrcA];
> diff --git a/target-tilegx/helper.h b/target-tilegx/helper.h
> index fd5517e..644d313 100644
> --- a/target-tilegx/helper.h
> +++ b/target-tilegx/helper.h
> @@ -1,4 +1,6 @@
>  DEF_HELPER_2(exception, noreturn, env, i32)
>  DEF_HELPER_FLAGS_1(cntlz, TCG_CALL_NO_RWG_SE, i64, i64)
>  DEF_HELPER_FLAGS_1(cnttz, TCG_CALL_NO_RWG_SE, i64, i64)
> +DEF_HELPER_FLAGS_1(pcnt, TCG_CALL_NO_RWG_SE, i64, i64)
> +DEF_HELPER_FLAGS_1(revbits, TCG_CALL_NO_RWG_SE, i64, i64)
>  DEF_HELPER_FLAGS_3(shufflebytes, TCG_CALL_NO_RWG_SE, i64, i64, i64, i64)
> diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c
> index 6b5de55..c2f38f1 100644
> --- a/target-tilegx/translate.c
> +++ b/target-tilegx/translate.c
> @@ -177,6 +177,43 @@ static void gen_saturate_op(TCGv tdest, TCGv tsrca, TCGv 
> tsrcb,
>      tcg_temp_free(t0);
>  }
>
> +/* Shift the 128-bit value TSRCA:TSRCD riht by the number of bytes


Typo: "right".

Otherwise

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM