Re: [Qemu-devel] [PATCH v16 02/35] linux-user: Support tilegx architecture in linux-user

[Peter Maydell]

On 14 September 2015 at 23:43, Richard Henderson <address@hidden> wrote:
> From: Chen Gang <address@hidden>
>
> Add main working flow feature, system call processing feature, and elf64
> tilegx binary loading feature, based on Linux kernel tilegx 64-bit
> implementation.
>
> [rth: Moved all of the implementation of atomic instructions to a later 
> patch.]
>
> Signed-off-by: Chen Gang <address@hidden>
> Reviewed-by: Peter Maydell <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>

> +static void gen_sigsegv_mapper(CPUTLGState *env, target_ulong addr)
> +{
> +    target_siginfo_t info;
> +
> +    info.si_signo = TARGET_SIGSEGV;
> +    info.si_errno = 0;
> +    info.si_code = TARGET_SEGV_MAPERR;
> +    info._sifields._sigfault._addr = addr;
> +    queue_signal(env, info.si_signo, &info);
> +}

Missed this in my earlier review, but there's a typo
in this function name -- it should be gen_sigsegv_maperr,
to match the si_code value.

(You can retain my R-by and fix the typo.)

thanks
-- PMM