[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 13/26] qapi: Clean up after recent conversion
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v7 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor |
Date: |
Tue, 15 Sep 2015 08:03:10 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/15/2015 04:52 AM, Daniel P. Berrange wrote:
> On Mon, Sep 14, 2015 at 07:57:44PM +0200, Markus Armbruster wrote:
>> Generate just 'FOO' instead of 'struct FOO' when possible.
>>
>> Drop helper functions that are now unused.
>>
>> Make pep8 and pylint reasonably happy.
>>
>> Rename generate_FOO() functions to gen_FOO() for consistency.
>>
>> Use more consistent and sensible variable names.
>>
>> Consistently use c_ for mapping keys when their value is a C
>> identifier or type.
>>
>> Simplify gen_enum() and gen_visit_union()
>>
>> Consistently use single quotes for C text string literals.
>
> I would have preferred to see one type of change per
> patch to make review easier, but this has been through
> enough iterations now that no point changing again.
I made the same comment back on v3 or v4, and the conclusion from then
still holds now - it was less churn to take it as is (since we have
clients waiting on the patch to get in) than to worry about splitting
and reviewing that the split is sane. :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v7 17/26] qapi: De-duplicate parameter list generation, (continued)
- [Qemu-devel] [PATCH v7 05/26] tests/qapi-schema: Convert test harness to QAPISchemaVisitor, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 10/26] qapi-event: Eliminate global variable event_enum_value, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 22/26] qom: Don't use 'gen': false for qom-get, qom-set, object-add, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 07/26] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 06/26] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 24/26] qapi: Pseudo-type '**' is now unused, drop it, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 15/26] qapi-commands: Rearrange code, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 26/26] qapi-introspect: Hide type names, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 21/26] qapi: Introduce a first class 'any' type, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 18/26] qapi-commands: De-duplicate output marshaling functions, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 16/26] qapi: Rename qmp_marshal_input_FOO() to qmp_marshal_FOO(), Markus Armbruster, 2015/09/14