Re: [Qemu-devel] [PATCH PULL v2 00/11] Extract TLS handling code from VNC server

[Daniel P. Berrange]

On Tue, Sep 15, 2015 at 12:41:00PM +0100, Daniel P. Berrange wrote:
> On Tue, Sep 15, 2015 at 12:23:39PM +0100, Peter Maydell wrote:
> > On 15 September 2015 at 11:16, Daniel P. Berrange <address@hidden> wrote:
> > > The following changes since commit 
> > > 007e620a7576e4ce2ea6955541e87d8ae8ed32ae:
> > >
> > >   Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into 
> > > staging (2015-09-14 18:51:09 +0100)
> > >
> > > are available in the git repository at:
> > >
> > >   git://github.com/berrange/qemu.git tags/vnc-crypto-v8-for-upstream
> > >
> > > for you to fetch changes up to 63909633894a7d613aa80a32a827581da9bf5ad5:
> > >
> > >   ui: convert VNC server to use QCryptoTLSSession (2015-09-15 11:08:52 
> > > +0100)
> > >
> > > ----------------------------------------------------------------
> > > Merge vnc-crypto-v8
> > >
> > > ----------------------------------------------------------------
> > > Daniel P. Berrange (11):
> > >       qapi: allow override of default enum prefix naming
> > >       tests: remove repetition in unit test object deps
> > >       crypto: move crypto objects out of libqemuutil.la
> > >       qom: allow QOM to be linked into tools binaries
> > >       crypto: introduce new base module for TLS credentials
> > >       crypto: introduce new module for TLS anonymous credentials
> > >       crypto: introduce new module for TLS x509 credentials
> > >       crypto: add sanity checking of TLS x509 credentials
> > >       crypto: introduce new module for handling TLS sessions
> > >       ui: fix return type for VNC I/O functions to be ssize_t
> > >       ui: convert VNC server to use QCryptoTLSSession
> > 
> > This failed to build for me (x86_64/Linux):
> > 
> >   LINK  aarch64-linux-user/qemu-aarch64
> > gdbstub.o: In function `gdb_read_register':
> > /home/petmay01/linaro/qemu-for-merges/gdbstub.c:569: undefined
> > reference to `object_get_class'
> 
> Argh, sorry about that. I usually build w/ non-system emulators
> disabled and forget to check they still work. Will submit a
> v3 pull when I've ensured this builds with a fully enabled
> config

For the record, there were small bugs in patch 3 and 4. In the first
I accidentally missed out linkage of crypto/aes.o from the userspace
emulator, and in the second accidentally missed linkage of $(qom-obj-y)
from the userspace emulators. These are fixed in the v3 pull request
I'm about to send.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|