[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping an
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area |
|
Date: |
Tue, 15 Sep 2015 18:06:04 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 25/08/2015 18:03, Stefan Hajnoczi wrote:
>> >
>> > +static uint64_t get_file_size(int fd)
>> > +{
>> > + struct stat stat_buf;
>> > + uint64_t size;
>> > +
>> > + if (fstat(fd, &stat_buf) < 0) {
>> > + return 0;
>> > + }
>> > +
>> > + if (S_ISREG(stat_buf.st_mode)) {
>> > + return stat_buf.st_size;
>> > + }
>> > +
>> > + if (S_ISBLK(stat_buf.st_mode) && !ioctl(fd, BLKGETSIZE64, &size)) {
>> > + return size;
>> > + }
> #ifdef __linux__ for ioctl(fd, BLKGETSIZE64, &size)?
>
> There is nothing Linux-specific about emulating NVDIMMs so this code
> should compile on all platforms.
The code from block/raw-posix.c and block/raw-win32.c's raw_getlength
should probably be extracted to a new function in utils/, and reused here.
Paolo