[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset
From: |
Alex Williamson |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset |
Date: |
Tue, 15 Sep 2015 15:19:42 -0600 |
On Mon, 2015-04-13 at 02:32 +0300, Nadav Amit wrote:
> Due to old Seabios bug, QEMU reenable LINT0 after reset. This bug is long gone
> and therefore this hack is no longer needed. Since it violates the
> specifications, it is removed.
>
> Signed-off-by: Nadav Amit <address@hidden>
> ---
> hw/intc/apic_common.c | 9 ---------
> 1 file changed, 9 deletions(-)
Please see bug: https://bugs.launchpad.net/qemu/+bug/1488363
Is this bug perhaps not as long gone as we thought, or is there
something else going on here? Thanks,
Alex
> diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
> index 042e960..d38d24b 100644
> --- a/hw/intc/apic_common.c
> +++ b/hw/intc/apic_common.c
> @@ -243,15 +243,6 @@ static void apic_reset_common(DeviceState *dev)
> info->vapic_base_update(s);
>
> apic_init_reset(dev);
> -
> - if (bsp) {
> - /*
> - * LINT0 delivery mode on CPU #0 is set to ExtInt at initialization
> - * time typically by BIOS, so PIC interrupt can be delivered to the
> - * processor when local APIC is enabled.
> - */
> - s->lvt[APIC_LVT_LINT0] = 0x700;
> - }
> }
>
> /* This function is only used for old state version 1 and 2 */
- Re: [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset,
Alex Williamson <=