Re: [Qemu-devel] [PATCH v8 07/26] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs

[Eric Blake]

On 09/16/2015 05:06 AM, Markus Armbruster wrote:
> Fixes flat unions to visit the base's base members (the previous
> commit merely added them to the struct).  Same test case.
> 

> Test cases updated for the bug fix.
> 
> Fixes alternates to generate a visitor for their implicit enumeration
> type.  None of them are currently used, obviously.  Example:
> block-core.json's BlockdevRef now generates
> visit_type_BlockdevRefKind().
> 
> The previous commit's two ugly special cases exist here, too.  Mark
> both TODO.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---

> +
> +    def visit_enum_type(self, name, info, values, prefix):
> +        self.decl += gen_visit_decl(name, scalar=True)
> +        self.defn += generate_visit_enum(name)

Not even used; just part of the overriding contract. I don't know if
python has any convention for marking known-unused parameters, so this
looks okay to me :)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature