[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 09/26] qapi: De-duplicate enum code generatio
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v8 09/26] qapi: De-duplicate enum code generation |
Date: |
Wed, 16 Sep 2015 11:16:51 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/16/2015 05:06 AM, Markus Armbruster wrote:
> Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but
> that's no excuse. Move the helpers from qapi-types.py to qapi.py, and
> replace the duplicates in qapi-event.py.
>
> The generated event enumeration type's lookup table becomes
> const-correct (see commit 2e4450f), and uses explicit indexes instead
> of relying on order (see commit 912ae9c).
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> docs/qapi-code-gen.txt | 9 ++++---
> scripts/qapi-event.py | 67
> +++-----------------------------------------------
> scripts/qapi-types.py | 55 -----------------------------------------
> scripts/qapi.py | 55 +++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 64 insertions(+), 122 deletions(-)
>
> +++ b/scripts/qapi.py
> @@ -1497,6 +1497,61 @@ def guardend(name):
> ''',
> name=guardname(name))
>
> +def generate_enum_lookup(name, values, prefix=None):
To keep pep8 happier, you could use two blank lines before def here...
> + return ret
> +
> +def generate_enum(name, values, prefix=None):
and here. Then again, 13/26 does more of these sorts of cleanups, and
v7 had the same use of 1 blank line. Up to you if it is worth avoiding
the churn; but it is whitespace either way so it doesn't affect review.
Also, do you still need prefix=None, or can we rely on the fact that now
all callers supply prefix by virtue of the visitor callback, and make
the parameter non-optional?
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v8 07/26] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs, (continued)
- [Qemu-devel] [PATCH v8 03/26] qapi: QAPISchema code generation helper methods, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 20/26] qapi: Make output visitor return qnull() instead of NULL, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 17/26] qapi: De-duplicate parameter list generation, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 18/26] qapi-commands: De-duplicate output marshaling functions, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 22/26] qom: Don't use 'gen': false for qom-get, qom-set, object-add, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 09/26] qapi: De-duplicate enum code generation, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 05/26] tests/qapi-schema: Convert test harness to QAPISchemaVisitor, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 15/26] qapi-commands: Rearrange code, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 24/26] qapi: Pseudo-type '**' is now unused, drop it, Markus Armbruster, 2015/09/16