|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH v8 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor |
Date: | Wed, 16 Sep 2015 11:20:15 -0600 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/16/2015 05:06 AM, Markus Armbruster wrote: > Generate just 'FOO' instead of 'struct FOO' when possible. > > Drop helper functions that are now unused. > > Make pep8 and pylint reasonably happy. > > Rename generate_FOO() functions to gen_FOO() for consistency. > > Use more consistent and sensible variable names. > > Consistently use c_ for mapping keys when their value is a C > identifier or type. > > Simplify gen_enum() and gen_visit_union() > > Consistently use single quotes for C text string literals. > > Signed-off-by: Markus Armbruster <address@hidden> > --- Diff from v7 limited to handling of enum prefix. Reviewed-by: Eric Blake <address@hidden> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] | Current Thread | [Next in Thread] |