[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 16/24] tcg: Move tci_tb_ptr to -common
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PULL 16/24] tcg: Move tci_tb_ptr to -common |
Date: |
Wed, 16 Sep 2015 21:58:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 |
Am 16.09.2015 um 21:14 schrieb Peter Crosthwaite:
> On Wed, Sep 16, 2015 at 10:50 AM, Stefan Weil <address@hidden> wrote:
>> Am 16.09.2015 um 14:29 schrieb Paolo Bonzini:
>>> From: Peter Crosthwaite <address@hidden>
>>>
>>> This requires global visibility to common code. Move to tcg-common.
>>>
>>> Cc: Stefan Weil <address@hidden>
>>> Signed-off-by: Peter Crosthwaite <address@hidden>
>>> Message-Id: <address@hidden>
>>> Signed-off-by: Paolo Bonzini <address@hidden>
>>> ---
>>> tcg/tcg-common.c | 4 ++++
>>> tci.c | 6 ------
>>> 2 files changed, 4 insertions(+), 6 deletions(-)
>>>
>>
>> The original versions of patches 15 and 16 did not catch
>> my attention because To / Cc did not include my name.
>>
>> Maybe a problem with the git configuration on the sender side?
>>
>
> Sorry. I have fixed that issue (sneaky suppress-cc on my send-email script).
>
> Is the patch ok?
>
> Regards,
> Peter
It looks fine.
I'd keep the comment which you removed in tci.c and move it to
the code location where tci_tb_ptr is used. But that can be done
in a later patch, no need to disturb Paolo's pull request.
With your QEMU multi-arch modification and some smaller additional
patches it might become possible to build a single QEMU executable
which supports both interpreted and normal TCG, so the TCG interpreter
could be available by default. Users would need a command line option
like --enable-tci to enable it.
Regards
Stefan
- [Qemu-devel] [PULL 08/24] hmp-commands-info: move info_cmds content out of monitor.c, (continued)
- [Qemu-devel] [PULL 08/24] hmp-commands-info: move info_cmds content out of monitor.c, Paolo Bonzini, 2015/09/16
- [Qemu-devel] [PULL 07/24] i386/kvm: Hyper-v crash msrs set/get'ers and migration, Paolo Bonzini, 2015/09/16
- [Qemu-devel] [PULL 10/24] hmp-commands.hx: fix end of table info, Paolo Bonzini, 2015/09/16
- [Qemu-devel] [PULL 12/24] qemu-char: Use g_new() & friends where that makes obvious sense, Paolo Bonzini, 2015/09/16
- [Qemu-devel] [PULL 11/24] monitor: added generation of documentation for hmp-commands-info.hx, Paolo Bonzini, 2015/09/16
- [Qemu-devel] [PULL 13/24] cpu-exec: Migrate some generic fns to cpu-exec-common, Paolo Bonzini, 2015/09/16
- [Qemu-devel] [PULL 14/24] translate-all: Move tcg_handle_interrupt() to -common, Paolo Bonzini, 2015/09/16
- [Qemu-devel] [PULL 16/24] tcg: Move tci_tb_ptr to -common, Paolo Bonzini, 2015/09/16
[Qemu-devel] [PULL 15/24] tcg: split tcg_op_defs to -common, Paolo Bonzini, 2015/09/16
[Qemu-devel] [PULL 09/24] monitor: remove target-specific code from monitor.c, Paolo Bonzini, 2015/09/16
[Qemu-devel] [PULL 18/24] cputlb: move CPU_LOOP() for tlb_reset() to exec.c, Paolo Bonzini, 2015/09/16
[Qemu-devel] [PULL 17/24] translate: move real_host_page setting to -common, Paolo Bonzini, 2015/09/16
[Qemu-devel] [PULL 19/24] cputlb: Change tlb_set_dirty() arg to cpu, Paolo Bonzini, 2015/09/16
[Qemu-devel] [PULL 21/24] monitor: uninclude cpu_ldst, Paolo Bonzini, 2015/09/16
[Qemu-devel] [PULL 24/24] Revert "rcu: init rcu_registry_lock after fork", Paolo Bonzini, 2015/09/16