qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/7 v9] vhost-user multiple queue support


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH 0/7 v9] vhost-user multiple queue support
Date: Thu, 17 Sep 2015 15:23:55 +0300

On Tue, Sep 15, 2015 at 03:10:27PM +0800, Yuanhan Liu wrote:
> Hi,
> 
> Here is the updated patch set for enabling vhost-user multiple queue.
> This patch set introduces 2 more vhost user messages: 
> VHOST_USER_GET_QUEUE_NUM,
> for querying how many queues the backend supports, and 
> VHOST_USER_SET_VRING_ENABLE,
> for enabling/disabling a specific virt queue.
> 
> Both of the two new messages are treated as vhost protocol extension,
> and that's why Michaels's patch "vhost-user: add protocol feature
> negotiation" is also included here.
> 
> Patch 1-5 are all prepare works for actually enabling multiple queue.
> 
> Patch 6 is the major patch for enabling multiple queue, which also tries
> to address two major concerns from Michael: no feedback from backend if
> it can't support # of requested queues, and all messages are sent N time.
> It also fixes a hidden bug.
> 
> Patch 7 introduces the VHOST_USER_SET_VRING_ENABLE message, to enable
> or disable a specific vring.
> 
> Note that I haven't done any formal test yet, it just passes build
> test and basic functional test, such as it does exit when backend
> doesn't support # of requested queues. Here I sent it out just for
> more comments, and for avoiding spending too much effort on the wrong
> track.
> 

This looks reasonable to me.
Pls rebase, test and re-post with fixed numbering, and I can merge.
Please post the dpdk patches too (preferably Cc me) so
it's testable by others.

> 
> v9: - Per suggested by Jason Wang, patch 5 introduces a new vhost
>       backend method: vhost_backend_get_vq_index().
> 
>     - Use qemu_find_net_clients_except() at net/vhost-user.c for
>       gathering all related ncs so that we could register chr dev
>       event handler once. Which is also suggested by Jason Wang.
> 
> 
> Thanks.
> 
>     --yliu
> 
> ---
> Changchun Ouyang (2):
>   vhost-user: add multiple queue support
>   vhost-user: add a new message to disable/enable a specific virt queue.
> 
> Michael S. Tsirkin (1):
>   vhost-user: add protocol feature negotiation
> 
> Yuanhan Liu (4):
>   vhost-user: use VHOST_USER_XXX macro for switch statement
>   vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE
>   vhost-user: add VHOST_USER_GET_QUEUE_NUM message
>   vhost: introduce vhost_backend_get_vq_index method
> 
>  docs/specs/vhost-user.txt         |  75 +++++++++++++++++++-
>  hw/net/vhost_net.c                |  39 ++++++++--
>  hw/net/virtio-net.c               |   8 +++
>  hw/virtio/vhost-backend.c         |  10 ++-
>  hw/virtio/vhost-user.c            | 143 +++++++++++++++++++++++++++++++------
>  hw/virtio/vhost.c                 |  20 +++---
>  include/hw/virtio/vhost-backend.h |   4 ++
>  include/hw/virtio/vhost.h         |   2 +
>  include/net/vhost_net.h           |   3 +
>  linux-headers/linux/vhost.h       |   2 +-
>  net/vhost-user.c                  | 146 
> +++++++++++++++++++++++++++-----------
>  qapi-schema.json                  |   6 +-
>  qemu-options.hx                   |   5 +-
>  tests/vhost-user-test.c           |   2 +-
>  14 files changed, 380 insertions(+), 85 deletions(-)
> 
> -- 
> 1.9.0



reply via email to

[Prev in Thread] Current Thread [Next in Thread]