[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object |
Date: |
Thu, 17 Sep 2015 10:09:46 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/16/2015 07:23 PM, Yang Hongyang wrote:
>>> +{ 'enum': 'NetFilterChain',
>>> + 'data': [ 'all', 'in', 'out' ] }
>>
>> I don't see any other QMP usage of this enum anywhere in the series. Are
>> you planning on supporting QMP? If so, let's get that design discussion
>> started. If not, why not?
>
> This series is based on QOM, so the QMP command for object_add
> will use this enum, for example:
> 1 { "execute": "qmp_capabilities" }
> 2 { "execute": "object-add",
> 3 "arguments": { "qom-type": "filter-buffer",
> 4 "id": "f0",
> 5 "props": { "netdev": "bn0",
> 6 "chain": "in",
> 7 "interval": 2000 } } }
>
> for hmp:
> object_add filter-buffer,id=f0,netdev=bn0,chain=in,interval=1000
>
> command options:
> -object filter-buffer,id=f0,netdev=bn0,chain=in,interval=1000
Do these examples appear in the documentation anywhere? If not, it is
worth considering (maybe under 'object-add' in qmp-commands.hx, for
example).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v11 03/12] netfilter: hook packets before net queue send, Yang Hongyang, 2015/09/16
[Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object, Yang Hongyang, 2015/09/16
Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object, Markus Armbruster, 2015/09/24
Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object, Yang Hongyang, 2015/09/24
Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object, Markus Armbruster, 2015/09/24
Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object, Jason Wang, 2015/09/25
Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object, Markus Armbruster, 2015/09/25
Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object, Jason Wang, 2015/09/28