[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat un
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union |
Date: |
Thu, 17 Sep 2015 14:11:17 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/17/2015 08:34 AM, Eric Blake wrote:
>>
>> I apply Markus's v8 patch and this series, make check will fail:
>> TEST: tests/virtio-net-test... (pid=23648)
>> /x86_64/virtio/net/pci/basic:
>> qemu-system-x86_64: -netdev socket,fd=6,id=hs0: Invalid parameter 'fd'
>
> Oh dear. I guess I was focused on 'make check-qapi-schema', and forgot
> to test the rest of the suite. The bug is most likely in my patches,
> and will be fixed by the time I post v5, now that you've pointed it out
> to me.
Fix is simple: add this patch to your build:
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01650.html
I've rebased my git repo accordingly for now, and will post v5 later on
(I'm still working on other improvements, and may reshuffle patches
before actually getting to v5).
git fetch git://repo.or.cz/qemu/ericb.git qapi
http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH RFC v4 03/29] qapi: use 'type' in generated C code to match QMP union wire form, (continued)
- [Qemu-devel] [PATCH RFC v4 03/29] qapi: use 'type' in generated C code to match QMP union wire form, Eric Blake, 2015/09/10
- [Qemu-devel] [PATCH RFC v4 24/29] qapi: Implement boxed structs for commands/events, Eric Blake, 2015/09/10
- [Qemu-devel] [PATCH RFC v4 23/29] qapi: Plumb in 'box' to qapi generator lower levels, Eric Blake, 2015/09/10
- [Qemu-devel] [PATCH RFC v4 25/29] qapi: Support boxed unions, Eric Blake, 2015/09/10
- [Qemu-devel] [PATCH RFC v4 26/29] qapi: Clean up qapi.py per pep8, Eric Blake, 2015/09/10
- [Qemu-devel] [PATCH RFC v4 29/29] net: Complete qapi-fication of netdev_add, Eric Blake, 2015/09/10
- [Qemu-devel] [PATCH RFC v4 28/29] net: Use correct type for bool flag, Eric Blake, 2015/09/10
- [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union, Eric Blake, 2015/09/10
- Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union, Wen Congyang, 2015/09/17
- Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union, Eric Blake, 2015/09/17
- Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union,
Eric Blake <=
- Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union, Wen Congyang, 2015/09/17
- Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union, Markus Armbruster, 2015/09/18
- Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union, Wen Congyang, 2015/09/18
- Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union, Eric Blake, 2015/09/18
- Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union, Eric Blake, 2015/09/18
- Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union, Yang Hongyang, 2015/09/18
- Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union, Eric Blake, 2015/09/18