[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] hw/pci-host/piix: fix one file descriptor leak
From: |
Tiejun Chen |
Subject: |
[Qemu-devel] [PATCH] hw/pci-host/piix: fix one file descriptor leak |
Date: |
Fri, 18 Sep 2015 08:57:10 +0800 |
Commit 595a4f07d6bd (piix: create host bridge to passthrough)
introduced to leak of one file descriptor, "config_fd", now
just fix that.
CC: Michael S. Tsirkin <address@hidden>
CC: Stefano Stabellini <address@hidden>
CC: Paolo Bonzini <address@hidden>
Acked-by: Stefano Stabellini <address@hidden>
Signed-off-by: Tiejun Chen <address@hidden>
---
hw/pci-host/piix.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 1fb71c8..7d44228 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -775,15 +775,18 @@ static int host_pci_config_read(int pos, int len,
uint32_t val)
}
if (lseek(config_fd, pos, SEEK_SET) != pos) {
+ close(config_fd);
return -errno;
}
do {
rc = read(config_fd, (uint8_t *)&val, len);
} while (rc < 0 && (errno == EINTR || errno == EAGAIN));
if (rc != len) {
+ close(config_fd);
return -errno;
}
+ close(config_fd);
return 0;
}
--
1.9.1
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCH] hw/pci-host/piix: fix one file descriptor leak,
Tiejun Chen <=