[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/5] Enable fw_cfg DMA interface for x86
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v3 5/5] Enable fw_cfg DMA interface for x86 |
Date: |
Fri, 18 Sep 2015 12:58:42 +0200 |
Hi,
> - fw_cfg = fw_cfg_init_io(BIOS_CFG_IOPORT);
> + fw_cfg = fw_cfg_init_io_dma(BIOS_CFG_IOPORT, BIOS_CFG_IOPORT + 4, as);
> + as = g_malloc(sizeof(*as));
> + address_space_init(as, ram_below_4g, "pc.as");
> + fw_cfg = bochs_bios_init(as);
I think we can use address_space_memory on x86 too (and can remove the
AddressSpace argument to fw_cfg_init_io_dma).
Otherwise the series looks fine to me (and thanks for picking it up).
cheers,
Gerd
- Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM, (continued)
- Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM, Peter Maydell, 2015/09/18
- Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM, Laszlo Ersek, 2015/09/18
- Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM, Laszlo Ersek, 2015/09/18
- Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM, Marc Marí, 2015/09/18
- Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM, Laszlo Ersek, 2015/09/18
- Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM, Marc Marí, 2015/09/19
[Qemu-devel] [PATCH v3 3/5] Implement fw_cfg DMA interface, Marc Marí, 2015/09/18
[Qemu-devel] [PATCH v3 5/5] Enable fw_cfg DMA interface for x86, Marc Marí, 2015/09/18
Re: [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface, Kevin O'Connor, 2015/09/18
- Re: [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface, Marc Marí, 2015/09/18
- Re: [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface, Peter Maydell, 2015/09/18
- Re: [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface, Kevin O'Connor, 2015/09/18
- Re: [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface, Peter Maydell, 2015/09/19
- Re: [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface, Kevin O'Connor, 2015/09/19