[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Makefile: fix build when VPATH is outside GIT t
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] Makefile: fix build when VPATH is outside GIT tree |
Date: |
Fri, 18 Sep 2015 13:40:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 18/09/2015 12:01, Daniel P. Berrange wrote:
> Steve Ellcey / Leon Alrae reported that QEMU fails to build when
> the VPATH directory is outside of the GIT tree, and the system
> emulators & tools build is disabled. eg
>
> cd ..
> mkdir build
> cd build
> ../qemu/configure --disable-system --disable-tools
> make
> (...)
> make[1]: *** No rule to make target `../qom/object.o', needed by
> `qemu-aarch64'. Stop.
> make: *** [subdir-aarch64-linux-user] Error 2
>
> The problem is due to the fact that some sub directory deps
> were listed against SOFTMMU_SUBDIR_RULES instead of SUBDIR_RULES,
> so were only processed for system emulators, not user emalutors.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
Queued, thanks.
Paolo
> ---
> Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 291fb54..acd261d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -177,7 +177,6 @@ SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES))
>
> $(SOFTMMU_SUBDIR_RULES): $(block-obj-y)
> $(SOFTMMU_SUBDIR_RULES): $(crypto-obj-y)
> -$(SOFTMMU_SUBDIR_RULES): $(qom-obj-y)
> $(SOFTMMU_SUBDIR_RULES): config-all-devices.mak
>
> subdir-%:
> @@ -202,7 +201,7 @@ subdir-dtc:dtc/libfdt dtc/tests
> dtc/%:
> mkdir -p $@
>
> -$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y)
> +$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) $(qom-obj-y)
> $(crypto-aes-obj-$(CONFIG_USER_ONLY))
>
> ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS))
> romsubdir-%:
>