[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] Auto-generated IDs
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] Auto-generated IDs |
Date: |
Fri, 18 Sep 2015 15:06:25 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Jeff Cody <address@hidden> writes:
> Changes from RFC v1:
>
> Patch 1: Several typos / grammatical errors (thanks Eric, John)
> Make id_subsys_str[] const pointer to const strings (thanks Eric)
> Moved id_subsys_str[] out from id_generate() (thanks John)
> Assert on null string for given id (thanks Eric)
> Zero-pad the 2-digit random # (thanks John)
>
> Patch 2: None
>
> Born from the conversation on qemu-devel, this generation scheme uses the
> format ultimately proposed by Kevin, after list discussion.
>
> It attempts to keep the ID strings as small as possible, while fulfilling:
>
> 1.) Guarantee no collisions with a user-specified ID
> 2.) Identify the sub-system the ID belongs to
> 3.) Guarantee of uniqueness
> 4.) Spoiling predictibility, to avoid creating an assumption
> of object ordering and parsing (i.e., we don't want users to think
> they can guess the next ID based on prior behavior).
>
> See patch 1 for the generation scheme details.
Since PATCH 1 defines an ID for the qdev subsystem, I expected a patch
to put it to use. As long as there is none, PATCH 1 shouldn't define
ID_QDEV.
Looks good apart from a harmless off-by-one and a few style nits.
- Re: [Qemu-devel] [PATCH v2 1/2] util - add automated ID generation utility, (continued)