[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix wrong size of flash
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix wrong size of flash |
Date: |
Fri, 18 Sep 2015 15:45:39 +0100 |
On 17 September 2015 at 02:57, <address@hidden> wrote:
> From: Shannon Zhao <address@hidden>
>
> While virt machine creates two flash devices with total size 0x08000000,
> it wrongly uses this total size for each one. So it will overlap other
> MMIO spaces.
>
> Signed-off-by: Shannon Zhao <address@hidden>
Applied to target-arm.next, thanks.
Andrew suggested an update to the commit message, so I have edited it:
hw/arm/virt-acpi-build: Fix wrong size of flash in ACPI table
While virt machine creates two flash devices with total size 0x08000000,
the ACPI table generation code was wrongly using this total size as the
size of each flash device, so it would overlap other MMIO spaces.
Make each device entry in the table half the total; this brings the
ACPI table into line with the code which generates the device tree
and which creates the flash devices themselves.
thanks
-- PMM