qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 4/4] hmp: add monitor command to add/remove a


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v4 4/4] hmp: add monitor command to add/remove a child
Date: Fri, 18 Sep 2015 09:00:00 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 09/18/2015 04:13 AM, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> Cc: Luiz Capitulino <address@hidden>
> ---
>  hmp-commands.hx | 28 ++++++++++++++++++++++++++++
>  hmp.c           | 20 ++++++++++++++++++++
>  hmp.h           |  2 ++
>  3 files changed, 50 insertions(+)
> 

> +
> +STEXI
> address@hidden blockdev_child_add @var{parent device} @var{child device}

This produces poor-looking info that makes it appear that the command
takes 4 parameters, with two of those parameters both named 'device'.
I'd use just:

@item blockdev_child_add @var{parent} @var{child}


> +STEXI
> address@hidden blockdev_child_del @var{parent device} @var{child device}

Likewise.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]