[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 37/38] hmp: Add read-only-mode option to change c
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v5 37/38] hmp: Add read-only-mode option to change command |
Date: |
Fri, 18 Sep 2015 17:23:12 +0200 |
Expose the new read-only-mode option of 'blockdev-change-medium' for the
'change' HMP command.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
hmp-commands.hx | 20 +++++++++++++++++---
hmp.c | 22 +++++++++++++++++++++-
2 files changed, 38 insertions(+), 4 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index a511004..00fb390 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -194,8 +194,8 @@ ETEXI
{
.name = "change",
- .args_type = "device:B,target:F,arg:s?",
- .params = "device filename [format]",
+ .args_type = "device:B,target:F,arg:s?,read-only-mode:s?",
+ .params = "device filename [format [read-only-mode]]",
.help = "change a removable medium, optional format",
.mhandler.cmd = hmp_change,
},
@@ -206,7 +206,7 @@ STEXI
Change the configuration of a device.
@table @option
address@hidden change @var{diskdevice} @var{filename} address@hidden
address@hidden change @var{diskdevice} @var{filename} address@hidden
address@hidden
Change the medium for a removable disk device to point to @var{filename}. eg
@example
@@ -215,6 +215,20 @@ Change the medium for a removable disk device to point to
@var{filename}. eg
@var{format} is optional.
address@hidden may be used to change the read-only status of the device.
+It accepts the following values:
+
address@hidden @var
address@hidden retain
+Retains the current status; this is the default.
+
address@hidden read-only
+Makes the device read-only.
+
address@hidden read-write
+Makes the device writable.
address@hidden table
+
@item change vnc @var{display},@var{options}
Change the configuration of the VNC server. The valid syntax for @var{display}
and @var{options} are described at @ref{sec_invocation}. eg
diff --git a/hmp.c b/hmp.c
index 5ea7ef2..6e2bbc8 100644
--- a/hmp.c
+++ b/hmp.c
@@ -27,6 +27,7 @@
#include "qapi/opts-visitor.h"
#include "qapi/qmp/qerror.h"
#include "qapi/string-output-visitor.h"
+#include "qapi/util.h"
#include "qapi-visit.h"
#include "ui/console.h"
#include "block/qapi.h"
@@ -1315,9 +1316,16 @@ void hmp_change(Monitor *mon, const QDict *qdict)
const char *device = qdict_get_str(qdict, "device");
const char *target = qdict_get_str(qdict, "target");
const char *arg = qdict_get_try_str(qdict, "arg");
+ const char *read_only = qdict_get_try_str(qdict, "read-only-mode");
+ BlockdevChangeReadOnlyMode read_only_mode = 0;
Error *err = NULL;
if (strcmp(device, "vnc") == 0) {
+ if (read_only) {
+ monitor_printf(mon,
+ "Parameter 'read-only-mode' is invalid for VNC");
+ return;
+ }
if (strcmp(target, "passwd") == 0 ||
strcmp(target, "password") == 0) {
if (!arg) {
@@ -1327,7 +1335,19 @@ void hmp_change(Monitor *mon, const QDict *qdict)
}
qmp_change("vnc", target, !!arg, arg, &err);
} else {
- qmp_blockdev_change_medium(device, target, !!arg, arg, false, 0, &err);
+ if (read_only) {
+ read_only_mode =
+ qapi_enum_parse(BlockdevChangeReadOnlyMode_lookup,
+ read_only, BLOCKDEV_CHANGE_READ_ONLY_MODE_MAX,
+ BLOCKDEV_CHANGE_READ_ONLY_MODE_RETAIN, &err);
+ if (err) {
+ hmp_handle_error(mon, &err);
+ return;
+ }
+ }
+
+ qmp_blockdev_change_medium(device, target, !!arg, arg,
+ !!read_only, read_only_mode, &err);
if (err &&
error_get_class(err) == ERROR_CLASS_DEVICE_ENCRYPTED) {
error_free(err);
--
2.5.2
- [Qemu-devel] [PATCH v5 25/38] blockdev: Allow more options for BB-less BDS tree, (continued)
- [Qemu-devel] [PATCH v5 25/38] blockdev: Allow more options for BB-less BDS tree, Max Reitz, 2015/09/18
- [Qemu-devel] [PATCH v5 27/38] blockdev: Add blockdev-open-tray, Max Reitz, 2015/09/18
- [Qemu-devel] [PATCH v5 28/38] blockdev: Add blockdev-close-tray, Max Reitz, 2015/09/18
- [Qemu-devel] [PATCH v5 29/38] blockdev: Add blockdev-remove-medium, Max Reitz, 2015/09/18
- [Qemu-devel] [PATCH v5 31/38] blockdev: Implement eject with basic operations, Max Reitz, 2015/09/18
- [Qemu-devel] [PATCH v5 32/38] blockdev: Implement change with basic operations, Max Reitz, 2015/09/18
- [Qemu-devel] [PATCH v5 33/38] block: Inquire tray state before tray-moved events, Max Reitz, 2015/09/18
- [Qemu-devel] [PATCH v5 30/38] blockdev: Add blockdev-insert-medium, Max Reitz, 2015/09/18
- [Qemu-devel] [PATCH v5 35/38] hmp: Use blockdev-change-medium for change command, Max Reitz, 2015/09/18
- [Qemu-devel] [PATCH v5 34/38] qmp: Introduce blockdev-change-medium, Max Reitz, 2015/09/18
- [Qemu-devel] [PATCH v5 37/38] hmp: Add read-only-mode option to change command,
Max Reitz <=
- [Qemu-devel] [PATCH v5 38/38] iotests: Add test for change-related QMP commands, Max Reitz, 2015/09/18
- [Qemu-devel] [PATCH v5 36/38] blockdev: read-only-mode for blockdev-change-medium, Max Reitz, 2015/09/18
- Re: [Qemu-devel] [PATCH v5 00/38] blockdev: BlockBackend and media, Kevin Wolf, 2015/09/22